[PATCH 0/2] Depends-on-CONFIG_MFD_CS5535 patchset

[Philip Prindeville]

[I'm not on linux-kernel or I'd reply directly...]

I'm looking at this proposed patch and thinking it's unnecessary and perhaps even mildly incorrect:

http://comments.gmane.org/gmane.linux.kernel/1162140

There is no direct dependency from LEDS_NET5501 or GEODE_WDT on MFD_CS5535.

There *is*, however, a dependency from LEDS_5501 onto CS5535_GPIO, which then depends on MFD_CS5535.

Ditto with there being a dependency of GEODE_WDT on CS5535_MFGPT, which also then depends on MFD_CS5535.

The first dependency was addressed by commit 04830fccdcafa7e0ea913990ae56437253553fef:

commit 04830fccdcafa7e0ea913990ae56437253553fef
Merge: 571503e 1486a74
Author: Linus Torvalds <torvalds at linux-foundation.org>
Date: Sat May 28 10:56:34 2011 -0700

Merge branch 'gpio/next' of git://git.secretlab.ca/git/linux-2.6

* 'gpio/next' of git://git.secretlab.ca/git/linux-2.6:
gpio/pch_gpio: Support new device ML7223
gpio: make gpio_{request,free}_array gpio array parameter const
GPIO: OMAP: move to drivers/gpio
GPIO: OMAP: move register offset defines into <plat/gpio.h>
gpio: Convert gpio_is_valid to return bool
gpio: Move the s5pc100 GPIO to drivers/gpio
gpio: Move the s5pv210 GPIO to drivers/gpio
gpio: Move the exynos4 GPIO to drivers/gpio
gpio: Move to Samsung common GPIO library to drivers/gpio
gpio/nomadik: add function to read GPIO pull down status
gpio/nomadik: show all pins in debug
gpio: move Nomadik GPIO driver to drivers/gpio
gpio: move U300 GPIO driver to drivers/gpio
langwell_gpio: add runtime pm support
gpio/pca953x: Add support for pca9574 and pca9575 devices
gpio/cs5535: Show explicit dependency between gpio_cs5535 and mfd_cs5535


and the later was addressed by the patch I sent a couple of days ago.

So I'd suggest that this proposed patch be rejected.

Bjarke's issues will be resolved when the above two patches make their way back down to him.

Anyone else?

-Philip